Closed hannahhoward closed 1 month ago
I'm with @alanshaw's sentiments. I think if we have a test failure, that should be a blocker: either we confirm that the test is unnecessary, or we fix it. To do otherwise degrades our confidence in our continuous delivery, and the whole thing falls apart.
That said, it doesn't need to block everyone. We can operate with slightly less confidence for a limited time.
I recommend we merge this and escalate the card that resolves, so that one person is blocked on it while everyone else can move forward with slightly more caution.
That said, it doesn't need to block everyone. We can operate with slightly less confidence for a limited time.
I recommend we merge this and escalate the card that resolves, so that one person is blocked on it while everyone else can move forward with slightly more caution.
+1 I should have cross posted here but I did suggest this same resolution in Discord.
@alanshaw Added to top of sprint as https://github.com/storacha-network/project-tracking/issues/129. Good to merge this PR?
Goals
currently, seed.run PRs fail 90%+ of the time because of the Filecoin test.
until we have a more reliable way to test the filecoin flow, the PR disables it.
the inserted comment suggests a few solutions -- either spinning up custom infra for w3filecoin pipeline on each pr to get more reliable results, or mocking out the pipeline
either way, this is the temporary fix -- I don't want to put in extra retries or anything -- we just need to find a better way to test, or investigate if there are in fact underlying issues, but in the meantime, other PRs need to get merged.