Open kloczek opened 2 years ago
Here is pytest output:
And yet another issie.
When pep517 is used generated .whl file contains etc/libreport/events.d/blivet-gui_event.conf file which is instaleld by pip install --root </install/prefix>
under python sitlib directory
[tkloczko@devel-g2v blivet-gui-2.3.0]$ unzip -l dist/blivet_gui-2.3.0-py3-none-any.whl
Archive: dist/blivet_gui-2.3.0-py3-none-any.whl
Length Date Time Name
--------- ---------- ----- ----
1318 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/appdata/blivet-gui.appdata.xml
215 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/applications/blivet-gui.desktop
4323 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/css/rectangle.css
72 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/img/line.png
1734 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/about_dialog.ui
3408 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/add_disklabel_dialog.ui
40662 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/blivet-gui.ui
6403 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/cache_area.ui
2232 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/confirm_actions_dialog.ui
2944 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/confirm_delete_dialog.ui
1556 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/confirm_dialog.ui
3079 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/custom_dialog.ui
4108 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/encryption_chooser.ui
1606 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/error_dialog.ui
5367 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/exception_dialog.ui
9241 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/format_dialog.ui
1561 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/info_dialog.ui
4694 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/label_dialog.ui
3511 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/luks_passphrase_dialog.ui
5011 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/mountpoint_dialog.ui
1666 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/parent_area.ui
4371 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/parent_chooser.ui
1665 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/raid_chooser.ui
3462 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/resize_dialog.ui
2625 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/root_check_window.ui
2291 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/show_actions_dialog.ui
1919 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/size_area.ui
2053 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/size_chooser.ui
6088 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/unmount_dialog.ui
1595 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/blivet-gui/ui/warning_dialog.ui
842 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/16x16/apps/blivet-gui.png
1228 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/22x22/apps/blivet-gui.png
1450 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/24x24/apps/blivet-gui.png
42850 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/256x256/apps/blivet-gui.png
2230 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/32x32/apps/blivet-gui.png
3996 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/48x48/apps/blivet-gui.png
5368 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/icons/hicolor/64x64/apps/blivet-gui.png
755 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/man/man1/blivet-gui.1
810 08-08-2021 15:09 blivet_gui-2.3.0.data/data/share/polkit-1/actions/org.fedoraproject.pkexec.blivet-gui.policy
3822 06-16-2022 12:02 blivet_gui-2.3.0.data/scripts/blivet-gui
3099 06-16-2022 12:02 blivet_gui-2.3.0.data/scripts/blivet-gui-daemon
50 08-08-2021 15:09 blivetgui/__init__.py
3439 08-08-2021 15:09 blivetgui/actions_menu.py
4240 08-08-2021 15:09 blivetgui/actions_toolbar.py
64810 06-16-2022 12:02 blivetgui/blivet_utils.py
34119 08-08-2021 15:09 blivetgui/blivetgui.py
1885 08-08-2021 15:09 blivetgui/config.py
3643 08-08-2021 15:09 blivetgui/exception_handler.py
2379 08-08-2021 15:09 blivetgui/gui_utils.py
1388 08-08-2021 15:09 blivetgui/i18n.py
5902 06-16-2022 12:02 blivetgui/list_actions.py
7026 08-08-2021 15:09 blivetgui/list_devices.py
3349 08-08-2021 15:09 blivetgui/list_parents.py
13633 08-08-2021 15:09 blivetgui/list_partitions.py
2997 08-08-2021 15:09 blivetgui/loading_window.py
4195 08-08-2021 15:09 blivetgui/logs.py
2189 08-08-2021 15:09 blivetgui/main_menu.py
10356 08-08-2021 15:09 blivetgui/osinstall.py
6977 06-16-2022 12:02 blivetgui/processing_window.py
0 08-08-2021 15:09 blivetgui/communication/__init__.py
9977 08-08-2021 15:09 blivetgui/communication/client.py
86 08-08-2021 15:09 blivetgui/communication/constants.py
1219 08-08-2021 15:09 blivetgui/communication/errors.py
2122 08-08-2021 15:09 blivetgui/communication/proxy_utils.py
11505 08-08-2021 15:09 blivetgui/communication/server.py
76 08-08-2021 15:09 blivetgui/dialogs/__init__.py
41383 08-08-2021 15:09 blivetgui/dialogs/add_dialog.py
76 08-08-2021 15:09 blivetgui/dialogs/constants.py
12183 08-08-2021 15:09 blivetgui/dialogs/device_info_dialog.py
27246 08-08-2021 15:09 blivetgui/dialogs/edit_dialog.py
6244 08-08-2021 15:09 blivetgui/dialogs/helpers.py
11833 08-08-2021 15:09 blivetgui/dialogs/message_dialogs.py
4284 08-08-2021 15:09 blivetgui/dialogs/other_dialogs.py
34208 08-08-2021 15:09 blivetgui/dialogs/size_chooser.py
12802 08-08-2021 15:09 blivetgui/dialogs/widgets.py
0 08-08-2021 15:09 blivetgui/visualization/__init__.py
10847 08-08-2021 15:09 blivetgui/visualization/logical_view.py
8435 08-08-2021 15:09 blivetgui/visualization/physical_view.py
5071 08-08-2021 15:09 blivetgui/visualization/rectangle.py
243 08-08-2021 15:09 etc/libreport/events.d/blivet-gui_event.conf <<<<==== HERE
18092 06-16-2022 12:02 blivet_gui-2.3.0.dist-info/COPYING
236 06-16-2022 12:02 blivet_gui-2.3.0.dist-info/METADATA
92 06-16-2022 12:02 blivet_gui-2.3.0.dist-info/WHEEL
10 06-16-2022 12:02 blivet_gui-2.3.0.dist-info/top_level.txt
8767 06-16-2022 12:02 blivet_gui-2.3.0.dist-info/RECORD
--------- -------
596844 85 files
Part of rpmbuild output
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/tkloczko/rpmbuild/BUILDROOT/blivet-gui-2.3.0-7.fc35.x86_64
error: Installed (but unpackaged) file(s) found:
/usr/lib/python3.8/site-packages/etc/libreport/events.d/blivet-gui_event.conf
I've removed the blivet-gui_event.conf
installation in #353, the config file is kinda Fedora-specific thing and it doesn't really make sense to have it in handled by setup.py
.
As for the test failures. These are caused by the test not being to able to find the .ui
files, which makes sense because these are in the blivet_gui-2.3.0.data/data/share/blivet-gui/ui/
where the code doesn't look for them. I really hate to be that developer, but I am going to give you the standard "it works for me" answer. It would be great to comply with the PEP517, but I unfortunately don't have capacity to work on that and the standard make && make install "works for me", so for now I can only give you another cliché answer "patches welcome", sorry. I might have some time to look into this in the future, but I can't promise anything.
If that file is needed IMO it would be good to leave it in git repo to be able use it during packaging process. My understanding is that this file should be installed as /etc/libreport/events.d/blivet-gui_event.conf. Is that correct?
If that file is needed IMO it would be good to leave it in git repo to be able use it during packaging process.
I didn't remove the file from the git repo.
My understanding is that this file should be installed as /etc/libreport/events.d/blivet-gui_event.conf. Is that correct?
Yes, but this makes sense only on systems with libreport/ABRT so I moved the installation step to the SPEC file.
ValueError: Namespace Gtk not available
Missing Gtk GI bindings.
E AttributeError: module 'selinux' has no attribute 'is_selinux_enabled'
Not sure what happened here, what's your version of libselinux python bindings?
Not sure what happened here, what's your version of libselinux python bindings?
3.6
Weird, we also have 3.6 in the latest Fedora and I am not seeing this.
I'm trying to package your module as an rpm package. So I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modules