search

storaged-project / blivet

A python module for configuration of block devices
GNU Lesser General Public License v2.1
97 stars 85 forks source link

drop python<=3.7 support #1218

Open kloczek opened 4 months ago

kloczek commented 4 months ago

Filter all python code over pyuprade --py38-plus and mark in setup.py that this module is only for python>=3.8.

StorageGhoul commented 4 months ago

Can one of the admins verify this patch?

vojtechtrefny commented 4 months ago

Jenkins, ok to test.

kloczek commented 4 months ago

I don't see a reason for dropping the <= 3.7 support

blivet module is used by blivet-gui. At the moment it is not possible to build full GUI desktop without at least python 3.10 (mesa, some parts of gnome during build and rust rpm base tooling needs python>=3.10).

IIRC fc38 uses python 3.10 or 3.11 so with current CI definition it is not possible to test this module with python<=3.9.

In other words it is nothing more than just cutting some legacy tail 😋

vojtechtrefny commented 3 months ago

In other words it is nothing more than just cutting some legacy tail

Asi I said, I am not against doing this, but currently the tests are failing (static analysis is complaining about indentation) so if you want this merged, please fix the failures first.

kloczek commented 3 months ago

Is it any problem with merge this PR an add indentation fixes?