search

storaged-project / blivet

A python module for configuration of block devices
GNU Lesser General Public License v2.1
99 stars 85 forks source link

move Blivet class into a separate module (blivet.py) #24

Closed vpodzime closed 9 years ago

vpodzime commented 9 years ago

Having the Blivet class defined in the blivet/init.py is bad for many reasons the most itchy one being the fact that if somebody wants to import something small and standalone like "from blivet.arch import isARM", many things that are required by the Blivet class get imported/processed too. Blivet as a module provides many useful functions that are not depending on the Blivet class so it should allow and support their usage without processing all the stuff required by the Blivet class.

The issue is that this would break the API quite seriously

dwlehman commented 9 years ago

We're about to do the 1.0 release. That might be the perfect time to break API. Once uevents and libblockdev are done and somewhat stable we might go ahead with a 2.0 release, which would be another opportunity to do this.

vpodzime commented 9 years ago

patch sent to anaconda-patches

vpodzime commented 9 years ago

This has been resolved with the merge of pull #27