search

storaged-project / libbytesize

A tiny library providing a C "class" for working with arbitrary big sizes in bytes
GNU Lesser General Public License v2.1
21 stars 21 forks source link

Can `--privileged` option for `docker run` be removed for ppc64le #84

Closed gururajrkatti closed 3 years ago

gururajrkatti commented 3 years ago

I am running the build and test as a part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing.

During the build and test (DOCKER_FILE=".travis/Dockerfile.debian-testing"), I found that it makes use of --privileged for docker run.

It fails for ppc64le since privileged containers are not supported for lxd backend. I also verified that without using this option, the travis build succeeds for ppc64le.

Wanted to check if it is okay to remove this option for ppc64le or is there any specific reason for including --privileged option.

vojtechtrefny commented 3 years ago

I think the privileged option shouldn't be needed, but Travis has a different opinion, see #85 But if it works for you, feel free to remove it.

gururajrkatti commented 3 years ago

Sure @vojtechtrefny, I will raise PR by removing it for ppc64le alone.

vojtechtrefny commented 3 years ago

Fixed in #87