search

storageos / deploy

MIT License
21 stars 11 forks source link

Fix etcd binary name #98

Closed luigidifraia closed 4 years ago

luigidifraia commented 4 years ago

Fix etcd binary name in chmod command

avestuk commented 4 years ago

@luigidifraia Thanks very much for opening this PR. My colleague @Arau has actually got this change lined up in a different PR https://github.com/storageos/deploy/pull/95 - https://github.com/storageos/deploy/blob/5da21d52dfd3b9eebc2ceee97b3c3f4b308c8676/k8s/deploy-storageos/etcd-helpers/etcd-ansible-systemd/roles/install_etcd/tasks/main.yml#L20-L31

The other PR is ready to merge today so I think we will just fix it in the other PR. Thank you again for your contribution.

Arau commented 4 years ago

We have merged https://github.com/storageos/deploy/pull/95 that has this same change, it also adds support for starting etcd using fqdn vs ip, the generation of certificates and TLS setup between peers, client auth + TLS.

Thank you @luigidifraia! I'm closing the PR 😄