Get rid of wait calls and increase reliability in threaded tests

storborg / manhattan

A gentleman's cocktail, for civilized analytics and testing

Other

2 stars 3 forks source link

Open storborg opened 12 years ago

storborg commented 12 years ago

The thread-based approach is obnoxious to test, because incorrectly behaving threads may live longer than expected, and synchronization is difficult.

Possible solutions could be:

Switch the server/worker/log stack to gevent, so that Greenlets can be killed reliably.
Use proper synchronization mechanisms, like threading Events / locks / semaphores for various steps of processing.
Eliminate the need to spawn threads at all in tests.

storborg commented 11 years ago

I'm pretty sure this is causing some spurious failures in tests, as well.

In production it's not really a huge issue, because there's no expectation of data being perfectly realtime anyways.