storefront-foundation / react-storefront

React Storefront - PWA for eCommerce. 100% offline, platform agnostic, headless, Magento 2 supported. Always Open Source, Apache-2.0 license. Join us as contributor (contributors@reactstorefront.io).

https://www.reactstorefront.io

Other

796 stars 190 forks source link

Accessibility issue with Quantity Selector #204

Open developeryashraj opened 2 years ago

developeryashraj commented 2 years ago

Bug report

Describe the bug

Need to swap aria-label for add and substract quantity buttons

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

Go to https://demo.reactstorefront.io/p/3
Do inspect on quantity buttons
Check the labels are coming wrong currently

Expected behavior

Plus icon should have aria-label as "add one quantity" and Minus icon should have aria-label as "Substract one quantity"

Screenshots

System information

OS: [e.g. macOS, Windows]
Browser (if applies) [e.g. chrome, safari]
Version of React Storefront: [e.g. 7.0.2]

Additional context

Add any other context about the problem here.