search

storeman-developers / harbour-storeman

OpenRepos client app for SailfishOS
https://openrepos.net/content/olf/storeman-installer
Other
52 stars 15 forks source link

[Bug] When an installation fails, Storeman endlessly displays "Installing" on the app page #288

Open Olf0 opened 2 years ago

Olf0 commented 2 years ago

SailfishOS VERSION (Settings → About product → Build): 3.2.1
HARDWARE (Settings → About product → Manufacturer & Product name): Xperia X
Storeman VERSION (Storeman → [Top pulley] About Storeman): 0.2.8, 0.2.10 & 0.3.0

BUG DESCRIPTION

When an installation fails, Storeman endlessly displays "Installing" with a spinning circle on the page of the failed app. One can go elsewhere in Storeman and return to the page of the failed app, it will still display "Installing" and the circle will be spinning, until Storeman is closed and reopened.

STEPS TO REPRODUCE

Try to install an app, which is known to fail installing, because some dependency is not met.

Expected behaviour

Storeman should cease displaying "Installing" and stop showing the spinning circle, when the corresponding failure notification is emitted.

ADDITIONAL INFORMATION

Needs to be retested / confirmed on SailfishOS 4.x.y.

Screenshot depicting the issue: Screenshot_20220403_002

nephros commented 2 years ago

Relevant pieces in the code:

Spinners:

running status:

So the two spinners are shown or hidden depending on the 'running' status, which is bound to certain states in PackageInformation.qml lines 58ff. It appears the state stays at "OrnPm.PackageInstalling" forever for some reason.

Olf0 commented 2 years ago

So the two spinners are shown or hidden depending on the 'running' status, which is bound to certain states in PackageInformation.qml lines 58ff. It appears the state stays at "OrnPm.PackageInstalling" forever for some reason.

Does this statement imply that you can reproduce this issue on SFOS 4.x.y? Or was it just a first code analysis WRT this issue?

In either case, thank you for looking at this!

nephros commented 2 years ago

On Saturday, 16 July 2022, olf wrote:

Does this statement imply that you can reproduce this issue on SFOS 4.x.y? Or was it just a first code analysis WRT this issue?

Well I have seen the 'endless spinner' several times on 4.x. But not related to an installation failing, just general updating.

So no I have not reproduced in that sense, and commented just to point out where to look.

Which I will do some more "soon".

-- Sent from my Sailfish device

Olf0 commented 2 years ago

Which I will do some more "soon".

Take your time; so "Jolla-soon" is fine for me. Having you involved with Storeman already is a psychological uplift for me, because maintaining it alone became a dead end in terms of motivation, quality assurance, skills and workload.