Closed BlackDuck888 closed 8 years ago
Kad has a pluggable transport adapter interface. It ships with support for UDP, TCP, and HTTP. The line you referenced from the test suite happens to be testing against the UDP adapter. We use our own custom transport adapter that extends kad's HTTP adapter.
Reference:
Package Versions
Replace the values below using the output from
npm list storj
.Replace the values below using the output from
node --version
.Expected Behavior
I expect that UPNP is used to open all needed ports and protocolls.
Actual Behavior
UPNP is used to open only tcp ports right now. In https://github.com/kadtools/kad/blob/86e29eef2ae3aec66d7502054c37cea5c9f0d78e/test/router.unit.js#L108 it look like for me, that udp is used for communication. UPNP users will not reached in this case, if i am correct.
Steps to Reproduce
Please include the steps the reproduce the issue, numbered below. Include as much detail as possible.