storj-archived / core

Deprecated. Implementation of the Storj v2 protocol for Node.js.
https://storj.io
Other
395 stars 88 forks source link

v6.2.1 (shard reaper key lookup rework) #663

Closed lilyannehall closed 7 years ago

lilyannehall commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e6306bea79616c891d45bc636e8bc6b923530c36 on bookchin:master into 1f9ee91134af25ada243140596618fff68488ae2 on Storj:master.

littleskunk commented 7 years ago

I don't see the fix for https://github.com/Storj/storjshare-daemon/issues/74 In my case the shard reaper was running but didn't print out anything on the logfile.

Looks like the logger is empty and we are using a new Logger with loglevel 0 here: https://github.com/Storj/core/blob/2742d487491e485274e1c3c50c47447f426917ba/lib/storage/manager.js#L34

lilyannehall commented 7 years ago

@littleskunk that needs to be done in the daemon package. i have it staged for pr once this is merged.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e008f5ff22a44fde6dc0235714b6572a9b1d8d20 on bookchin:master into 1f9ee91134af25ada243140596618fff68488ae2 on Storj:master.

braydonf commented 7 years ago

LGTM. We'll need to update mongodb-adapter

ne0ark commented 7 years ago

Seems like this has popped up again? https://github.com/Storj/storjshare-daemon/issues/247