search

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.
https://storj.io
MIT License
23 stars 19 forks source link

Implement downloader #106

Closed marcorosa closed 7 years ago

marcorosa commented 7 years ago

Implementation of a downloader (as an external file and class). Once the PR is merged, we can consider integrating it with the Client

marcorosa commented 7 years ago

Also the downloader, like the uploader, uses functions from the FileCrypto class. So it is better to take it out from uploader.py

steenzout commented 7 years ago

@marcorosa conflicting files ^.

marcorosa commented 7 years ago

@steenzout I have a lot of print function. The plan was to implement a downloader, make a PR with it and then do some code refactoring to replace all the print funcitons with loggers (and then do a second PR). But if you think that loggers should be implemented before this PR, I'll integrate them now.

steenzout commented 7 years ago

@marcorosa let's do it now.

marcorosa commented 7 years ago

Everything should be ok now. Does pep8 want a blank line at the end of files? I see opposing opinions about it

marcorosa commented 7 years ago

With the last commit I've changed the occurrences of + with %s in the strings