2016.09.07 update - Githubissues

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.

https://storj.io

MIT License

23 stars 19 forks source link

2016.09.07 update #11

Closed steenzout closed 8 years ago

steenzout commented 8 years ago

added integration tests
added more unit tests (and a few stub methods)
change code modules, classes, etc to be more Python-like
added docstring
bucket functions for the HTTP client pass integration tests

I'll keep working on this but this PR would be useful to merge to have future contributions (by others) based on this branch.

coveralls commented 8 years ago

Coverage decreased (-13.4%) to 25.885% when pulling d157514e015ef883e56bdc8e9010aecf11ac0932 on steenzout:cleanup into b91d537b2c259ad58854b90c71fd409e6eb52e6e on Storj:master.

coveralls commented 8 years ago

Coverage decreased (-13.4%) to 25.885% when pulling d157514e015ef883e56bdc8e9010aecf11ac0932 on steenzout:cleanup into b91d537b2c259ad58854b90c71fd409e6eb52e6e on Storj:master.

coveralls commented 8 years ago

Coverage decreased (-14.3%) to 25.047% when pulling 85c955fe81dda949b0f2a761adddee03e1519997 on steenzout:cleanup into b91d537b2c259ad58854b90c71fd409e6eb52e6e on Storj:master.

coveralls commented 8 years ago

Coverage decreased (-14.3%) to 25.047% when pulling dc61d3bf47f0bf4cf9deec969bfa40560a8c2ac5 on steenzout:cleanup into b91d537b2c259ad58854b90c71fd409e6eb52e6e on Storj:master.

coveralls commented 8 years ago

Coverage decreased (-14.3%) to 25.047% when pulling dc61d3bf47f0bf4cf9deec969bfa40560a8c2ac5 on steenzout:cleanup into b91d537b2c259ad58854b90c71fd409e6eb52e6e on Storj:master.

coveralls commented 8 years ago

Coverage decreased (-14.3%) to 25.047% when pulling 4dfcd5e69b2fb35307dcf51b6665132f9a28b0b7 on steenzout:cleanup into b91d537b2c259ad58854b90c71fd409e6eb52e6e on Storj:master.

Miskerest commented 8 years ago

Should I go ahead and merge despite Travis and coveralls warnings?

steenzout commented 8 years ago

@Miskerest I would say so.

the travis-ci is failing on Python 3.4 and 3.3 but working on 3.5. py27 and pypy also pass.

considering the amount of code added it was expected coveralls to complain (lower coverage).

I'm tackling that but it will take a bit of time :)

Miskerest commented 8 years ago

@super3 To give the user a chance to cancel in case they don't want their keys deleted.

super3 commented 8 years ago

@Miskerest Probably should just give them a prompt then.