integration test for model.py _make_shards()

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.

https://storj.io

MIT License

23 stars 19 forks source link

integration test for model.py _make_shards() #110

Closed steenzout closed 5 years ago

steenzout commented 7 years ago

write integration test first to determine what is the current behavior (small file and large file > sys.maxsize)
rewrite the _make_shards() function in a way that still passes the same test #109

instead of doing chunk_size calculation when
arriving at the last chunk `(file size - N chunks * chunk_size)` it
would be better to simply read `chunk_size` bytes out of the file at
a time which should handle the last chunk being less than `chunk_size

RichardLitt commented 5 years ago

👋 Hey! Thanks for this contribution. Apologies for the delay in responding!

We've decided to rearchitect Storj, so that we can scale better. You can read more about this decision here. This means that we are entirely focused on v3 at the moment, in the storj/storj repository. Our white paper for v3 is coming very, very soon - follow along on the blog and in our Rocketchat.

As this repository is part of the v2 network, we're no longer maintaining this repository. I am going to close this for now. If you have any questions, I encourage you to jump on Rocketchat and ask them there. Thanks!