search

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.
https://storj.io
MIT License
23 stars 19 forks source link

Implement multiprocessing in file upload #114

Closed marcorosa closed 7 years ago

marcorosa commented 7 years ago

Use a Pool for uploading shards, instead of launching single threads every time (consistency with the downloader). For uploading a file, use the method file_upload instead of createNewUploadThread (more user friendly). Some class variables have been deleted (e.g., the bucket id.. keeping it as a class variable has no sense)

steenzout commented 7 years ago

only 1 comment.

rest looks good.

Miskerest commented 7 years ago

Builds failing on Travis, is this an issue?

steenzout commented 7 years ago

@Miskerest the build needs to pass so whatever is making it fail needs to be changed.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 47.206% when pulling 1c4b93e8327d169d65df3fcfa97e0534b31a49f2 on marcorosa:multiprocessing into 343666754fdefa7e378b631e5681f89e3023ebbc on Storj:develop.

Miskerest commented 7 years ago

Building passing. Merging & closing.