Pep8 Compliance - Githubissues

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.

https://storj.io

MIT License

23 stars 19 forks source link

Pep8 Compliance #13

Closed prestwich closed 8 years ago

prestwich commented 8 years ago

I made my pep8 linter stop yelling at me. Tried to make styling consistent across files, and err on the side of not making changes.

Some comments are still too long. I wasn't sure how to address those, and I don't know that I was consistent.

I left a few warnings in docs/conf.py related to this line: sys.path.insert(0, os.path.abspath('..')) The warnings were E402 module level import not at top of file. I was unsure whether modifying the path affected those imports.

prestwich commented 8 years ago

Broken build is because Master is currently broken.

I think. May have found an error.

coveralls commented 8 years ago

Changes Unknown when pulling adc515814a637f985837846eb70e9423174b49d9 on frdwrd:pep8 into \ on Storj:master**.

coveralls commented 8 years ago

Changes Unknown when pulling adc515814a637f985837846eb70e9423174b49d9 on frdwrd:pep8 into \ on Storj:master**.

coveralls commented 8 years ago

Changes Unknown when pulling adc515814a637f985837846eb70e9423174b49d9 on frdwrd:pep8 into \ on Storj:master**.

prestwich commented 8 years ago

Ah! Fixed it!

Tox.ini now ignores styling error W503, as PEP8 now officially recommends the opposite of what the linter checks for. Line breaks before binary operators are now recommended.

steenzout commented 8 years ago

looks good to me.

coveralls commented 8 years ago

Changes Unknown when pulling 1cfc25a9db138bdb8a1bc84649e40fe98bbc7a44 on frdwrd:pep8 into \ on Storj:master**.

steenzout commented 8 years ago

looks good!

coveralls commented 8 years ago

Changes Unknown when pulling 3f4f0a0caf06807e15a43e92e1d046bee2d59093 on frdwrd:pep8 into \ on Storj:master**.

prestwich commented 8 years ago

This is ready to be merged, btw

super3 commented 8 years ago

ACK