storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.
https://storj.io
MIT License
23 stars 19 forks source link

bucket_files name is misleading #21

Closed prestwich closed 8 years ago

prestwich commented 8 years ago

In http.py, I would expect bucket_files() to get a list of all files in a bucket. Instead it gets the pointers for a specific file. I can't find a function to list the files in a bucket.

Current functionality: bucket_files gets file pointers via GET /buckets/{id}/files/{file_id}

Proposed change bucket_files should list files in a bucket via GET /buckets/{id}/files file_pointers should get file pointers via GET /buckets/{id}/files/{file_id}

steenzout commented 8 years ago

why not bucket_file_pointers? you're still working on a bucket domain.

prestwich commented 8 years ago

All of the endpoints for file-related operations are actually variations on /buckets/{id}/file/. We already have file_get, file_upload, file_delete. file_pointers is consistent with these.

steenzout commented 8 years ago

got it.