[WIP] More tests, various fixes

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.

https://storj.io

MIT License

23 stars 19 forks source link

[WIP] More tests, various fixes #26

Closed prestwich closed 8 years ago

prestwich commented 8 years ago

Do not merge. Still a work in progress.

I'm a little worried that I messed up merging in master. Can I get a careful code review?

coveralls commented 8 years ago

Coverage increased (+5.06%) to 48.893% when pulling 88f8700ae20d54ddcb286847ff35f4b2ff6a627c on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

prestwich commented 8 years ago

Still don't merge. :)

Feedback needed on test_file_download. I have a bunch of stuff commented out that needs work.

coveralls commented 8 years ago

Coverage increased (+5.06%) to 48.893% when pulling e7678d4e51a7b06755d6260c8b1ea8368b3830b4 on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

coveralls commented 8 years ago

Coverage increased (+5.06%) to 48.893% when pulling ebb1a798925454b7bbb50ad07b7b62b65f158fb8 on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

coveralls commented 8 years ago

Coverage increased (+7.4%) to 51.197% when pulling 34044d7e41e70e0cc5961396c75f53964671f288 on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

prestwich commented 8 years ago

Dang. Forgot to check py35 locally before pushing the commit.

coveralls commented 8 years ago

Coverage increased (+7.4%) to 51.197% when pulling 71dfad775b7d2c61a29e1335ba0c97c4d6ed1380 on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

coveralls commented 8 years ago

Coverage increased (+8.1%) to 51.934% when pulling 9870c4f28051a441dbf4de005497f614aa0ae0ed on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

coveralls commented 8 years ago

Coverage increased (+9.9%) to 53.775% when pulling 82a208e2b986ad4827e69b0b2b700b1d3a5eb101 on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

prestwich commented 8 years ago

Made both recommended changes. Is string formatting always faster than concatenation?

coveralls commented 8 years ago

Coverage increased (+9.9%) to 53.775% when pulling 510056efb97859d6f6fdf161940f6549d123c62f on frdwrd:master into 2b50ffb35aa2a8e897a9b73dd7f92f95319c2e66 on Storj:master.

steenzout commented 8 years ago

linking #14 to this issue.

steenzout commented 8 years ago

@frdwrd yes I think so.

you can check this link

note when writing log messages you should build the messages the following way:

self.logger.info('parameter x=%s y=%s', x, y)
# not
# self.logger.info('parameter x=%s y=%s' % (x, y))

coveralls commented 8 years ago

Coverage increased (+10.03%) to 53.775% when pulling 7529b9f6b4068a36357eb1084819946673f19325 on frdwrd:master into 2d63fff9bc9bf52443eb21662825e54dd3c51bfb on Storj:master.

prestwich commented 8 years ago

This is ready to merge afaik.