search

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.
https://storj.io
MIT License
23 stars 19 forks source link

Use better source of randomness #38

Closed prestwich closed 5 years ago

prestwich commented 7 years ago

Best practices suggest os.urandom or random.SystemRandom

steenzout commented 7 years ago

reference

Miskerest commented 7 years ago

Is this in reference to _get_random_challenge_string?

steenzout commented 7 years ago

I think so.

prestwich commented 7 years ago

Yeah that's what brought it to my attention. I noticed a few other places where we could use non-reproducible randomness, like in Keyring.

Miskerest commented 7 years ago

Okay, I think this was fixed in the last commit but I'll leave it open as a reminder to use os.urandom in te future like in Keyring as @frdwrd mentioned.

RichardLitt commented 5 years ago

👋 Hey! Thanks for this contribution. Apologies for the delay in responding!

We've decided to rearchitect Storj, so that we can scale better. You can read more about this decision here. This means that we are entirely focused on v3 at the moment, in the storj/storj repository. Our white paper for v3 is coming very, very soon - follow along on the blog and in our Rocketchat.

As this repository is part of the v2 network, we're no longer maintaining this repository. I am going to close this for now. If you have any questions, I encourage you to jump on Rocketchat and ask them there. Thanks!