james merkle improvements and cleanup

storj-archived / storj-python-sdk

Deprecated. A Python SDK for the Storj API.

https://storj.io

MIT License

23 stars 19 forks source link

james merkle improvements and cleanup #40

Closed steenzout closed 7 years ago

steenzout commented 7 years ago

close #39
removed duplicate hash functions
use generators to send leaves to the MerkleTree
added properties to encapsulate behavior
cleanup initializers
added tests for ShardManager
includes @frdwrd improvements: #31

@Miskerest @super3 please review! thank you!

coveralls commented 7 years ago

Coverage increased (+8.8%) to 62.562% when pulling 7af027f964a6d347bc2f3daa1d756a000341b0d2 on steenzout:merkle2 into 28319c2877e6810ff22096fcd30c8c8b73b0e395 on Storj:master.

super3 commented 7 years ago

Looks alright to me. Defer to @frdwrd on this because it looks like he still has some stuff he wants to complete on the merkle tree trip.

prestwich commented 7 years ago

These changes look great. This invalidates my open PR, #31, as it includes all of the changes. I can add the remaining things on my to-do list with a further PR after this gets merged.