Closed steenzout closed 7 years ago
pycoin
is not Python 3.x compatible.
storj/model.py:220: in __init__
self.keypair = BIP32Node.from_master_secret(secret)
.tox/py35/lib/python3.5/site-packages/pycoin/key/BIP32Node.py:67: in from_master_secret
I64 = hmac.HMAC(key=b"Bitcoin seed", msg=master_secret, digestmod=hashlib.sha512).digest()
.tox/py35/lib/python3.5/hmac.py:84: in __init__
self.update(msg)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <hmac.HMAC object at 0x7f76be808a20>, msg = 'master_password'
def update(self, msg):
"""Update this hashing object with the string msg.
"""
> self.inner.update(msg)
E TypeError: Unicode-objects must be encoded before hashing
.tox/py35/lib/python3.5/hmac.py:93: TypeError
sync'ed with #61 .
pycoin
doesn't support Python3 so removed that classifier and allowed tests to fail.
@BlackDuck888 ping.
closed by #64
61 + increased test coverage, consistent docstring and more Pythonic approach.
@Miskerest please review.
thank you!