storj-archived / storjshare-daemon

Deprecated. Docker Daemon + CLI for farming data on the Storj v2 network.
https://storj.io/share.html
GNU Affero General Public License v3.0
331 stars 74 forks source link

Daemon crashes when it receives invalid input #325

Closed fcro closed 6 years ago

fcro commented 6 years ago

Package Versions

Replace the values below using the output from storjshare --version.

daemon: 5.3.0, core: 8.5.0, protocol: 1.2.0

Replace the values below using the output from node --version.

v6.13.0

Expected Behavior

The daemon should reply with an error message.

Actual Behavior

The daemon crashes without error.

Steps to Reproduce

  1. Connect to the daemon with nc or any similar network tool.
    $ nc -vv localhost 45015
    localhost.localdomain [127.0.0.1] 45015 (?) open
    {"method":"methods","arguments":[{"start":"[Function]","stop":"[Function]","restart":"[Function]","status":"[Function]","killall":"[Function]","destroy":"[Function]","save":"[Function]","load":"[Function]"}],"callbacks":{"0":["0","start"],"1":["0","stop"],"2":["0","restart"],"3":["0","status"],"4":["0","killall"],"5":["0","destroy"],"6":["0","save"],"7":["0","load"]},"links":[]}
  2. Send the following JSON-formatted string. I didn't try with other JSON strings but I believe the result would be identical. {"method":"status"} nc should print the following before the connection gets closed: sent 20, rcvd 382
  3. Try to re-connect to the same port. The connection is refused because the daemon isn't running anymore.
    $ nc -vv localhost 45015
    localhost.localdomain [127.0.0.1] 45015 (?) : Connection refused
    sent 0, rcvd 0
RichardLitt commented 6 years ago

👋 Hey! Thanks for this contribution. Apologies for the delay in responding!

We've decided to rearchitect Storj, so that we can scale better. You can read more about this decision here. This means that we are entirely focused on v3 at the moment, in the storj/storj repository. Our white paper for v3 is coming very, very soon - follow along on the blog and in our Rocketchat.

As this repository is part of the v2 network, we're no longer maintaining this repository. I am going to close this for now. If you have any questions, I encourage you to jump on Rocketchat and ask them there. Thanks!