Open digglife opened 1 year ago
Hi @kmozurkewich @ayush-srivastava-03
Could you please review this fix? If you are no longer maintaining this project, do you know who should we contact for issue report or PR? Thanks!
Hello!
Thank you for the PR. Will get it in the queue for the end of next week.
Add Missing space before the git url. This problem causes git clone failure, so the whole share object building process doesn't work.
Remove
sudo
statements. If the package path is not writable to current user, then it should not be. We should let user to decide whether to usesudo
instead of prompt password in the middle of installing (Actually install to system site-packages with admin privilege is a bad practice). Also, if user is using virtualenv or install with--user
, it's perfectly fine withoutsudo
.Avoid echoing the output because system output is unpredictable. It could be multiple lines, so
os.system("echo ", output.decode("utf-8"))
could end up executing the following shell commandthe second line
andthe third line
will be executed as normal shell command.We don't need to use echo to print out the result.
os.exit(1)
should besys.exit(1)