search

storj-thirdparty / uplink-rust

Rust bindings for libuplink
25 stars 5 forks source link

all(build): Change shebang for better compatibility #66

Closed eopb closed 1 year ago

eopb commented 1 year ago

NixOS doesn't have #!/bin/bash. Bash can be found on all Linuxes with #!/usr/bin/env bash so it's better to use that shebang.

This doesn't actually enable building on NixOS since uplink-c also needs upgrading to a version that doesn't use #!/bin/bash. This was done in https://github.com/storj/uplink-c/pull/24

related https://github.com/storj-thirdparty/uplink-rust/issues/49

ifraixedes commented 1 year ago

Can you change the commit message?

The title should be something like all(build): Change shebang for better compatibility The body can be the same, but keep it no more than 75 columns wide.

Thank you for your contribution!

eopb commented 1 year ago

Can you change the commit message?

The title should be something like all(build): Change shebang for better compatibility The body can be the same, but keep it no more than 75 columns wide.

Thank you for your contribution!

@ifraixedes Fixed :)