storj-thirdparty / velero-plugin

Velero object store plugin that is backed by Storj
Apache License 2.0
8 stars 3 forks source link

Implement CreateSignedURL #6

Closed Fadila82 closed 4 years ago

Fadila82 commented 4 years ago

CreateSignedURL creates a pre-signed URL for the given bucket and key that expires after ttl.

It is used for downloading a backup with velero backup download backup-name

ifraixedes commented 4 years ago

It is used for downloading a backup with velero backup download bucketname

What do you mean? as far as I know, that command can be used with just passing the name of the backup.

Please, could you link to Velero docs, so I can read it and having a better understanding?

Fadila82 commented 4 years ago

It is used for downloading a backup with velero backup download bucketname

What do you mean? as far as I know, that command can be used with just passing the name of the backup.

Please, could you link to Velero docs, so I can read it and having a better understanding?

Sorry, I meant "backupname" but typed bucketname instead.

ifraixedes commented 4 years ago

@Fadila82 sorry I dropped 2 things in the same comment and probably it was unclear so I repeat the question

Please, could you link to Velero docs, so I can read it and having a better understanding?

ifraixedes commented 4 years ago

There is one only thing missing, updating the README

Now that the linksharing URL isn't passed through the Velero config, there is no need to update the README