storj / edge

Storj edge services (including multi-tenant, S3-compatible server to interact with the Storj network)
GNU Affero General Public License v3.0
48 stars 18 forks source link

Review MinIO's test suite (mint) to find potential improvements to requirements for Object Versioning #351

Closed ferristocrat closed 10 months ago

ferristocrat commented 11 months ago

Motivation/Why?

Our integration test suites are quite good at finding edge cases in certain features of S3. We should review them to find any potential edge cases that PRD doesn't list as requirements.

What needs to be done?

Review object versioning tests from MinIO's test suite (mint) to find any potential edge cases. Verify them against the Requirements section of this document.

Acceptance Criteria

Additional edge cases are reported in the document as suggestions or comments, and product managers are aware of changes that need to be made to the requirements documents.

Paul proposes to review JT's change to implement versioning in our MinIO fork (see https://github.com/storj/gateway-mt/issues/351#issuecomment-1679485153).

Links

ferristocrat commented 11 months ago

Make sure to cover the following S3 endpoints:

amwolff commented 11 months ago

JT says that MinIO's mint test suite is very basic and doesn't test the whole breadth of the versioning feature of the S3 protocol.

JT's change to implement versioning in our MinIO fork: https://review.dev.storj.io/c/storj/gateway/+/10925

Paul proposes to review JT's change as part of this task.