Adjust DeleteBucket satellite endpoint (governance & legal hold) - Githubissues

storj / edge

Storj edge services (including multi-tenant, S3-compatible server to interact with the Storj network)

GNU Affero General Public License v3.0

53 stars 18 forks source link

Adjust DeleteBucket satellite endpoint (governance & legal hold) #474

Closed ferristocrat closed 2 months ago

ferristocrat commented 3 months ago

Goal

This issue is to make meaningful progress on this design doc for Governance Mode and Legal Hold.

What needs to be done? • Acceptance Criteria

Modify the corresponding to DeleteBucket endpoint on the satellite (the endpoint might be named differently) to respect the Governance Mode and Legal Hold lock information.

You might need to adjust existing Object Lock machinery, and then this might already be done or there might something else to do in the endpoint's code as well.

Summary

Implementation reference.

Depends on…

466
467

Links

https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html
an easy-to-read and insightful introduction to Object Lock: Using S3 Object Lock

wilfred-asomanii commented 2 months ago

This looks to be covered by this as well

amwolff commented 2 months ago

@wilfred-asomanii maybe let's just add some more tests there

NiaStorj commented 2 months ago

@wilfred-asomanii hi, any update on Artur's comment from above?

wilfred-asomanii commented 2 months ago

There's a test each for this on the satellite, gateway, and I pushed a change to cover that in uplink