storj / gateway-st

Single-tenant, S3-compatible server to interact with the Storj network
Apache License 2.0
71 stars 19 forks source link

ListParts does not set the continuation token correctly #53

Closed amwolff closed 2 years ago

amwolff commented 2 years ago

What version of Gateway-ST are you using (gateway version)?

$ gateway version
5175572dcb9c5d20ea6d18cbf38af5a58b13e37c

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (uname -mrsv)?

uname -mrsv Output
$ uname -mrsv
Darwin 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:29:10 PST 2021; root:xnu-8019.61.5~1/RELEASE_ARM64_T8101 arm64

What did you do?

I listed the object's parts with a limit.

What did you expect to see?

The next part number marker is set to the last part number in the listing.

What did you see instead?

I didn't get the next part number marker.

The problematic line: https://github.com/storj/gateway-st/blob/5175572dcb9c5d20ea6d18cbf38af5a58b13e37c/miniogw/multipart.go#L259 (but there can be more problems).

storjBuildBot commented 2 years ago

Change https://review.dev.storj.io/c/storj/gateway/+/6886 mentions this issue.