Remove events chore from storjscan - Githubissues

storj / storjscan

GNU Affero General Public License v3.0

6 stars 2 forks source link

Remove events chore from storjscan #86

Closed dlamarmorgan closed 1 month ago

dlamarmorgan commented 1 month ago

The events chore added to storjscan leads to more requests to the infura API because we run multiple instances of the storjscan API. Instead use the satellite requests that come from the satellite core chore, which has only 1 instance, and rate limit these requests so they don't all query the infura node.

shaupt131 commented 1 month ago

Working on getting tests to pass before pushing for review.

Rate limiting is still affecting transactions hitting US1 promptly.

stretch goal to have this ready for review by tomorrow, either split on unsplit.

dlamarmorgan commented 1 month ago

https://review.dev.storj.io/c/storj/storjscan/+/13969 https://review.dev.storj.io/c/storj/storjscan/+/13970 https://review.dev.storj.io/c/storj/storjscan/+/13971

shaupt131 commented 1 month ago

Pushed for review.

Jen and Ivan will review.

shaupt131 commented 1 month ago

Fully merged. Cut a storjscan release branch yesterday and will be deployed to QA today. Damein will be checking the base functionality and checking infra statistics to see if the number of transactions decreases.

shaupt131 commented 1 month ago

This was deployed to QA and results were mixed. Investigating how to continue to improve. Pushed a new change for review.

Next steps:

Ivan to review https://review.dev.storj.io/c/storj/storjscan/+/14029

dlamarmorgan commented 1 month ago

Need a few more reviews https://review.dev.storj.io/c/storj/storjscan/+/14040 https://review.dev.storj.io/c/storj/storjscan/+/14043 https://review.dev.storj.io/c/storj/storjscan/+/14051

shaupt131 commented 1 month ago

Work completed since last standup:

Latest QA deployment indicated that we still had some issues to resolve
Damein pushed changes to resolve. Tested locally and it seemed to work very well with these latest changes.

Work to be completed by next standup:

Jen and Ivan to provide reviews for Damein as listed above

shaupt131 commented 1 month ago

Will be deploying to QA soon. Will need to perform quality checks before we deploy to other satellites, as well as wait for billing to finish.

shaupt131 commented 1 month ago

Has been tested by Damein and Andrii. Found to be reducing the number of requests by quite a bit, so things are looking good! Billing has completed, so Damein push the latest storjscan to all satellites.

shaupt131 commented 1 month ago

Has been pushed to all satellites. Storjscan transactions should be coming through promptly now. Issue closed.