Currently, checking upload limits (ExceedsUploadLimits) we are separately getting storage and segment limit from cache. We should be able to replace those two calls with single GetProjectLimits which returns all project limits (bandwidth, storage, segment). Code will be cleaner and method will execute slightly faster.
Acceptance Criteria:
update ExceedsUploadLimits to use GetProjectLimits instead GetProjectSegmentLimit and GetProjectStorageLimit separately
remove ProjectLimitCache.GetProjectSegmentLimit if its used only in ExceedsUploadLimits
check if we can also remove ProjectLimitCache.GetProjectStorageLimit if its not used in different places and remove it if possible
Qweder93
commented
2 years ago
Currently, checking upload limits (
ExceedsUploadLimits) we are separately getting storage and segment limit from cache. We should be able to replace those two calls with singleGetProjectLimitswhich returns all project limits (bandwidth, storage, segment). Code will be cleaner and method will execute slightly faster.Acceptance Criteria:
ExceedsUploadLimitsto useGetProjectLimitsinsteadGetProjectSegmentLimitandGetProjectStorageLimitseparatelyProjectLimitCache.GetProjectSegmentLimitif its used only inExceedsUploadLimitsProjectLimitCache.GetProjectStorageLimitif its not used in different places and remove it if possible