search

storj / team-metainfo

GNU Affero General Public License v3.0
0 stars 0 forks source link

Objects iterator should use SUBSTRING function in SQL query #56

Closed mniewrzal closed 2 years ago

mniewrzal commented 2 years ago

The issue is fixed in CRDB v20.2.5, which is already deployed on all satellites.

[https://github.com/cockroachdb/cockroach/issues/57367|https://github.com/cockroachdb/cockroach/issues/57367|smart-link]
Migrated from https://storjlabs.atlassian.net/browse/PG-176

mniewrzal commented 2 years ago

Commented by Michal Niewrzal

https://review.dev.storj.io/c/storj/storj/+/4052

mniewrzal commented 2 years ago

Commented by Michal Niewrzal

substring_in_listing_query.txt

I attached listing results from metabase-benchmark tool that compares current implementation and it looks that using SUBSTRING query directly in SQL query doesn’t affect performance in a negative way.

mniewrzal commented 2 years ago

Done with https://review.dev.storj.io/c/storj/storj/+/8356