storj / team-metainfo

GNU Affero General Public License v3.0
0 stars 0 forks source link

Technical debt - automated tests for security bugs #58

Open mniewrzal opened 2 years ago

mniewrzal commented 2 years ago

On 10/6/2020 we discovered we had a few security bugs in production. We created the PRs below to resolve these security bugs but since we wanted to hotfix these quickly we did not add automated tests to ensure they would not happen again. The purpose of this ticket is to backfill the automated tests for this PR’s.

PR’s:

AC:

mniewrzal commented 2 years ago

Commented by Ivan Fraixedes

Test for the PR 1 test is ready for a review

https://review.dev.storj.io/c/storj/storj/+/2804

mniewrzal commented 2 years ago

Commented by Ivan Fraixedes

The PR 3 test is ready for review.

Note the PR 3 added several tests to the changes but the GraphQL mutation that changed in that commit didn’t have a test and it was not added. My commit adds that missing test.

https://review.dev.storj.io/c/storj/storj/+/2807