search

storm-devs / storm-engine

Game engine behind Sea Dogs, Pirates of the Caribbean and Age of Pirates games.
https://storm-devs.github.io/storm-engine
GNU General Public License v3.0
842 stars 122 forks source link

Needs to be reverted #442

Open espkk opened 1 year ago

espkk commented 1 year ago

https://github.com/storm-devs/storm-engine/commit/7877868f8b44c206697845a85f60b2d6e3f5f6ca This causes quite noticeable performance regression and should be reverted somehow

espkk commented 1 year ago

context: making copy of FuncInfo (on each event call) triggers copying of vector of LocalVarInfo that leads to multiple heavy allocations on each frame I workarounded that on my local branch by putting LocalVarInfo into std::shared_ptr, but I'm not satisfied with this approach