search

storm-fsv-cvut / smoderp2d

SMODERP2D - Distributed event-based model for surface and subsurface runoff and erosion
https://storm-fsv-cvut.github.io/smoderp2d-manual/
GNU General Public License v3.0
9 stars 4 forks source link

Type of computing #171

Open kavkapet opened 1 year ago

kavkapet commented 1 year ago

Compute only surface runoff (sheet and rill) in case empty inpute stream data

jerabekjak commented 11 months ago

@landam @pesekon2 Which one is working now? Numbers of characters?

Screenshot from 2023-10-16 16-42-02

landam commented 11 months ago

@landam @pesekon2 Which one is working now? Numbers of characters?

@jerabekjak We switched to strings in June: https://github.com/storm-fsv-cvut/smoderp2d/commit/4c5e18f230fad83252c5f989707543c89100551d#diff-919ea52275af6d3e986f274bdf5eef6352a77d5d99b6b85999ff4fd1fa7ec04a

pesekon2 commented 11 months ago

@jerabekjak: The right one, using words. I have no idea why there are numbers in gistest, probably some ancient remnants. However, I have tried to change the value in gistest.ini and have found that it is probably not used at all. Even if I delete the .ini file, the tests pass. @landam: Is that correct? Isn't that wrong?

landam commented 11 months ago

@pesekon2 You are right, gistest.ini is not currently used. But it's planned to be used by test_002 (use dpre from test_001 + cmd provider): https://github.com/storm-fsv-cvut/smoderp2d/blob/master/tests/test_grass.py#L26