search

storm-fsv-cvut / smoderp2d

SMODERP2D - Distributed event-based model for surface and subsurface runoff and erosion
https://storm-fsv-cvut.github.io/smoderp2d-manual/
GNU General Public License v3.0
9 stars 4 forks source link

Support stream bifurcation #339

Open pesekon2 opened 6 months ago

pesekon2 commented 6 months ago

The code currently ends up in an error when there are three linestrings connected to one node in streams (error is raised by this part of the code). SMODERP2D should support this. Another problem is that the error does not occur when one linestring is connected to another one in the middle instead of at the very end (although there are also three linestrings coming out of a node then) so the behaviour is very different for the two very similar cases.

@kavkapet: Is there any recommended approach on how to solve it?

Streams that would cause this error in our rain simulator test data are attached: streams.zip

pesekon2 commented 6 months ago

The bug with three streams coming from one point was solved in #341. The problem with a line connected to the middle of another line (the point knows only about the connecting line) still stays. Also, real bifurcation (except those middle-line ones) are still not supported.

pesekon2 commented 6 months ago

The problem with a line connected to the middle of another line solved in 71f1933. The only missing thing is to support real bifurcation.