search

storm-fsv-cvut / smoderp2d

SMODERP2D - Distributed event-based model for surface and subsurface runoff and erosion
https://storm-fsv-cvut.github.io/smoderp2d-manual/
GNU General Public License v3.0
7 stars 4 forks source link

updating mat_aa for varying slopes #384

Open jerabekjak opened 2 months ago

jerabekjak commented 2 months ago

We need to recalculate the mas_aa matrix in [1] each time step since the slope is changing in the diffusive wave approximation. Now the mat_aa is calculated once in [2] (in 2d smoderp anyways).

[1] https://github.com/storm-fsv-cvut/smoderp2d/blob/7e0c98ff441533adc0d801d88485738fe7b0a94c/smoderp2d/providers/base/data_preparation.py#L20-L41

[2] https://github.com/storm-fsv-cvut/smoderp2d/blob/7e0c98ff441533adc0d801d88485738fe7b0a94c/smoderp2d/providers/base/data_preparation.py#L615-L617

kavkapet commented 2 months ago

How is possible rainfall amount in some points value = 251 m3/pixel image

kavkapet commented 2 months ago

and see issue https://github.com/storm-fsv-cvut/smoderp2d/issues/387, here you can see bad rainfall points

kavkapet commented 2 months ago

and problem with zero flow as in case aa == 0 in sheet flow is also in rill flow @pesekon2 or/and @jerabekjak...see surface.py image

pesekon2 commented 2 months ago

How is possible rainfall amount in some points value = 251 m3/pixel

Because it rains as hell in that place. We'll take a look at that. Thanks for reporting it.