search

storm-fsv-cvut / smoderp2d

SMODERP2D - Distributed event-based model for surface and subsurface runoff and erosion
https://storm-fsv-cvut.github.io/smoderp2d-manual/
GNU General Public License v3.0
9 stars 4 forks source link

review output arrays values #50

Open landam opened 4 years ago

landam commented 4 years ago

ArcGIS Toolbox run with test data gives strange output data

VirtualBox_Windows 10 (ArcGIS Pro)_05_10_2019_15_36_41

While test from command line

./bin/start-smoderp2d.py --typecomp roff --indata tests/test.ini

gives different values (some make sense from first POV)

2019-10-05 16:17:20,232 - SMODERP2D - INFO - Array stats: min=0.0 max=0.00284423793801 mean=0.00138464882653 - [__init__:379]
2019-10-05 16:17:20,232 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/cInfil_m3.asc saved - [__init__:99]
2019-10-05 16:17:20,233 - SMODERP2D - INFO - Array stats: min=0.0 max=0.0143333333333 mean=0.00776388888889 - [__init__:379]
2019-10-05 16:17:20,233 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/cRain_m3.asc saved - [__init__:99]
2019-10-05 16:17:20,233 - SMODERP2D - INFO - Array stats: min=0.0 max=0.00534586330829 mean=0.00145814946429 - [__init__:379]
2019-10-05 16:17:20,233 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/mVel_m_s.asc saved - [__init__:99]
2019-10-05 16:17:20,234 - SMODERP2D - INFO - Array stats: min=0.0 max=0.0518620497914 mean=0.015633564699 - [__init__:379]
2019-10-05 16:17:20,234 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/mrSearStr_Pa.asc saved - [__init__:99]
2019-10-05 16:17:20,234 - SMODERP2D - INFO - Array stats: min=0.0 max=9.33323751905e-05 mean=2.04181664011e-05 - [__init__:379]
2019-10-05 16:17:20,234 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/mQsur_m3_s.asc saved - [__init__:99]
2019-10-05 16:17:20,235 - SMODERP2D - INFO - Array stats: min=0.0 max=0.148485353763 mean=0.0326753520574 - [__init__:379]
2019-10-05 16:17:20,235 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/cVsur_m3.asc saved - [__init__:99]
2019-10-05 16:17:20,235 - SMODERP2D - INFO - Array stats: min=0.0 max=1.39237258423e-05 mean=5.44579206604e-06 - [__init__:379]
2019-10-05 16:17:20,235 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/mQsheet_m3_s.asc saved - [__init__:99]
2019-10-05 16:17:20,236 - SMODERP2D - INFO - Array stats: min=0.0 max=0.00273906893225 mean=0.000583630068854 - [__init__:379]
2019-10-05 16:17:20,236 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/mWLevelRill_m.asc saved - [__init__:99]
2019-10-05 16:17:20,237 - SMODERP2D - INFO - Array stats: min=0.0 max=7.94086531127e-05 mean=1.497236428e-05 - [__init__:379]
2019-10-05 16:17:20,237 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/mQRill_m3_s.asc saved - [__init__:99]
2019-10-05 16:17:20,238 - SMODERP2D - INFO - Array stats: min=0.0 max=0.0442320876233 mean=0.0118387686368 - [__init__:379]
2019-10-05 16:17:20,238 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/widthRill.asc saved - [__init__:99]
2019-10-05 16:17:20,238 - SMODERP2D - INFO - Array stats: min=0.0 max=0.137246258368 mean=0.0280351847523 - [__init__:379]
2019-10-05 16:17:20,238 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/cVIn_M3.asc saved - [__init__:99]
2019-10-05 16:17:20,239 - SMODERP2D - INFO - Array stats: min=0.0 max=0.00025 mean=0.000135416666667 - [__init__:379]
2019-10-05 16:17:20,239 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/surRet_M.asc saved - [__init__:99]
2019-10-05 16:17:20,239 - SMODERP2D - INFO - Array stats: min=0.0 max=0.0 mean=0.0 - [__init__:379]
2019-10-05 16:17:20,239 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/CumVRestL3.asc saved - [__init__:99]
2019-10-05 16:17:20,240 - SMODERP2D - INFO - Array stats: min=0.011662668472 max=3.40282346639e+38 mean=2.02042643317e+38 - [__init__:379]
2019-10-05 16:17:20,240 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/massBalance.asc saved - [__init__:99]
2019-10-05 16:17:20,241 - SMODERP2D - INFO - Array stats: min=-9999 max=1002 mean=-4446.55208333 - [__init__:379]
2019-10-05 16:17:20,241 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/reachFid.asc saved - [__init__:99]
2019-10-05 16:17:20,241 - SMODERP2D - INFO - Array stats: min=-3.40282346639e+38 max=0.0 mean=-2.02042643317e+38 - [__init__:379]
2019-10-05 16:17:20,241 - SMODERP2D - INFO - Raster ASCII output file tests/data/output/volRest_m3.asc saved - [__init__:99]

@jerabekjak Please review correctness of values.

jerabekjak commented 4 years ago

@landam The arcgis and cmd test runs did not use the same data and configuration (geodata and total time of comutation). After I unify it, the results looked the same (cmd run stores more rasters which is a matter of setting, I guess) figure: left cmd logging right arcgis logging image

jerabekjak commented 4 years ago

@landam The values make sense after a close look. The raster in arcgis provider however do not store no data value (something like -3.8e38) which is then operate with as a normal "number" which makes mess in the raster output statistics (in case of the first raster). Other raters have minimum 0 because zero is a stores outside the computation region instead of no data value.

jerabekjak commented 4 years ago

Correct results saving need to be done first. See e.g. commit 7dcc74322a9c45d53667407544777557917febea.

kavkapet commented 1 year ago

related to #135