search

storm345dev / ucars

The repo of ucars(bukkit)
10 stars 9 forks source link

1.17-Support #19

Closed Jakllp closed 3 years ago

Jakllp commented 3 years ago

Due to some NMS-Changes in 1.17 I had to make changes to the reflection and also the fields being altered.

Basically everything is repackaged and nearly all the fields got renamed and as for the pitch... It's in a different place now

Jakllp commented 3 years ago

Closed due to inconsistencies between paper and spigot

storm345 commented 3 years ago

Mostly alright, though ucars.version referring to the server version and not the version of the plugin is quite misleading and I would prefer if that was changed!

Jakllp commented 3 years ago

Done

storm345 commented 3 years ago

Hmm looking more closely what you have it totally fine but there would be a more robust way of coding your version check. Eg. if the version changed to 2.0.0 it would currently break. You could instead read the major.minor.minor2 version numbers via a regex and then compare properly eg. if major <= 1 and minor <= 16 then do the pre 1.17 behaviour, else do the new behaviour

storm345 commented 3 years ago

Sorry for not putting that in the first review, I know it can be a bit annoying having to keep going back and forth