stormcat24 / protodep

Collect necessary .proto files (Protocol Buffers IDL) and manage dependencies
Apache License 2.0
303 stars 57 forks source link

Option to shell out to git? #61

Open mmlb opened 3 years ago

mmlb commented 3 years ago

Maybe even by default?

I went looking to do something like #49 did because protodep's ssh logic was not working well for me and certainly would not work well in a shared repo. I use per-service/host ssh keys and I would have had to specify the key to use in my build scripts. My situation isn't that unique though, some people may have transitioned to ed25519 keys or something else where the default logic is invalid.

This isn't a problem with git&ssh since I can configure git to use http/ssh per repo and git will shell out to ssh which will use the correct key and config for the host from the .ssh/config settings.

By shelling out to git #43, #41, #40 would all go away.

If this sounds good to you I'll hack on this in my spare time and submit a PR.