search

stormcat24 / protodep

Collect necessary .proto files (Protocol Buffers IDL) and manage dependencies
Apache License 2.0
302 stars 57 forks source link

Add subgroup option. #69

Closed rcgoodfellow closed 3 years ago

rcgoodfellow commented 3 years ago

In GitLab it's possible to have subgroups to organize repositories. Protodep can not currently deal with this as it assumes the repo path follows GitHub rules and only contains github.com/$organization/$repo.

This commit adds a subgroup property to the dependency schema that allows the user to specify the subgroup or subgroups that are involved in the git URL reference. When the subgroup property is not present, the behavior remains unchanged so this should not be a breaking change.

As a concrete example consider this repo

https://gitlab.com/mergetb/portal/services

that has the structure https://gitlab.com/$group/$subgroup/$repo, in general arbitrary subgrouping on GitLab is possible https://gitlab.com/$gropup/$a/$b/$c/.../$repo.

Thanks for the very useful tool!

stormcat24 commented 3 years ago

Thank you for using protodep. Please wait a few days for review 🙏

sf-jassmith commented 3 years ago

@rcgoodfellow Great Fix! I am also using gitlab. Any chance you could make the suggested changes and get this merged soon?

rcgoodfellow commented 3 years ago

Requested changes have been made. Sorry for the delay.

stormcat24 commented 3 years ago

@rcgoodfellow Awesome works! Thanks! This feature has released in 0.1.5

@sf-jassmith Please use this version!