Validate `proto_outdir` exists - Githubissues

stormcat24 / protodep

Collect necessary .proto files (Protocol Buffers IDL) and manage dependencies

Apache License 2.0

294 stars 56 forks source link

Validate `proto_outdir` exists #82

Closed takumakanari closed 2 years ago

takumakanari commented 2 years ago

This PR adds that validate proto_outdir is definitely defined in toml.

Here is the reason why I added:

In the sync sequence, https://github.com/stormcat24/protodep/blob/master/service/sync.go#L76 removes all of the files under directly in outdir.
If we didn't set proto_outdir in toml, all of the files under s.conf.OutputDir (=repository root, in most cases) will be removed.
It's meaning of that there is a possibility we lose all files under the repository root.
This PR is to avoid behavior like this before checking out the .proto files.

stormcat24 commented 2 years ago

This feature is included in v0.1.6.