search

stormcat24 / protodep

Collect necessary .proto files (Protocol Buffers IDL) and manage dependencies
Apache License 2.0
294 stars 56 forks source link

proto-dep does not support repos with any group depth #95

Open seanamos opened 2 years ago

seanamos commented 2 years ago

While github.com only has repos (for now) with the following structure: github.com/{owner}/{repo}.git, other hosting services (gitlab.com) can have repos with the following structure: gitlab.com/a/b/c/d/e/f.git (subgroups).

When trying to use a repo like: gitlab.com/a/b/c/d as a target, proto-dep will try connect to ssh://gitlab.com/a/b.git.

The quick fix is to change pkg/config/schema.go/Repository() to return the target as specified. Testing locally, this just works. However, this is technically a breaking change.

stormcat24 commented 2 years ago

@seanamos Would you please send a pull request to this repository? I want to confirm and consider it.

seanamos commented 2 years ago

Sure, I can push what I have my side.

belenkoArrival commented 2 years ago

Is this still a problem? Currently trying to use subgroup paths (gitlab) and it seems to have the same issue.

seanamos commented 2 years ago

@belenkoArrival Yes the problem still exists. I apologize, I haven't had time to push up a PR with the fix (which is quite simple), my youngest son was born just a few days ago so I simply haven't had time.

seosite commented 2 years ago

look forward to solving this problem at an early date...

hr3685930 commented 2 years ago

look forward to solving this problem at an early date...