search

storming0x / serpentor

A set of smart contracts tools for governance written in vyper
GNU Affero General Public License v3.0
53 stars 5 forks source link

bump OZ contracts version, fix memory location mismatch #24

Closed z80dev closed 1 year ago

z80dev commented 1 year ago

I got this error when following the README instructions. Looks like a bug in the 4.4.2 Oz contracts release

> stderr:
Error: Data locations of parameters have to be the same when overriding non-external functions, but they differ.
   --> governance/Governor.sol:100:5:
    |
100 |     function hashProposal(
    |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Overridden function is here:
  --> governance/IGovernor.sol:92:5:

I confirmed the mismatch does exist in that release, see here:

IGovernor.sol

Governor.sol

After bumping the version in ape-config.yaml, I was able to build everything and run all tests as expected

storming0x commented 1 year ago

Thanks for the PR @z80dev LGTM!