storming0x / ystarter-foundry-kit

Starter Kit for integrating V2 yearn vaults and ERC4626 vaults
GNU Affero General Public License v3.0
49 stars 15 forks source link

Implement deposit correctly in adapter #5

Open storming0x opened 2 years ago

storming0x commented 2 years ago

At the moment the owner argument is not being used, given that we use the OZ ERC20 implementation its hard to access the allowances directly to check owner != msg.sender.

With some refactoring we can remove OZ ERC20 and switch it to solmate's implementation to be able to fully support deposits.