storming0x / ystarter-foundry-kit

Starter Kit for integrating V2 yearn vaults and ERC4626 vaults
GNU Affero General Public License v3.0
49 stars 15 forks source link

Handle unused shares for withdrawals #8

Open storming0x opened 2 years ago

storming0x commented 2 years ago

Remove this logic from original router and send back tokens instead of unusedshares, since this exposes the caller to the backing vault which is something we want to abstract away.

Return values should be in tokens if at all.

https://github.com/storming0x/ystarter-foundry-kit/blob/013cd2dc34242b1c3c0dc7af4df0a920068e7129/src/VaultWrapper.sol#L291