chore: bump node-forge from 1.2.1 to 1.3.0

dependabot[bot] commented 2 years ago

Bumps node-forge from 1.2.1 to 1.3.0.

Changelog

1.3.0 - 2022-03-17

Security

Three RSA PKCS#1 v1.5 signature verification issues were reported by Moosa Yahyazadeh (moosa-yahyazadeh@uiowa.edu).

HIGH: Leniency in checking digestAlgorithm structure can lead to signature forgery.

The code is lenient in checking the digest algorithm structure. This can allow a crafted structure that steals padding bytes and uses unchecked portion of the PKCS#1 encoded message to forge a signature when a low public exponent is being used. For more information, please see "Bleichenbacher's RSA signature forgery based on implementation error" by Hal Finney.

CVE ID: CVE-2022-24771

GHSA ID: GHSA-cfm4-qjh2-4765

HIGH: Failing to check tailing garbage bytes can lead to signature forgery.

The code does not check for tailing garbage bytes after decoding a DigestInfo ASN.1 structure. This can allow padding bytes to be removed and garbage data added to forge a signature when a low public exponent is being used. For more information, please see "Bleichenbacher's RSA signature forgery based on implementation error" by Hal Finney.

CVE ID: CVE-2022-24772

GHSA ID: GHSA-x4jg-mjrx-434g

MEDIUM: Leniency in checking type octet.

DigestInfo is not properly checked for proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.

CVE ID: CVE-2022-24773

GHSA ID: GHSA-2r2c-g63r-vccr

Fixed

[asn1] Add fallback to pretty print invalid UTF8 data.

[asn1] fromDer is now more strict and will default to ensuring all input bytes are parsed or throw an error. A new option parseAllBytes can disable this behavior.

NOTE: The previous behavior is being changed since it can lead to security issues with crafted inputs. It is possible that code doing custom DER parsing may need to adapt to this new behavior and optional flag.

[rsa] Add and use a validator to check for proper structure of parsed ASN.1 RSASSA-PKCS-v1_5 DigestInfo data. Additionally check that the hash algorithm identifier is a known value from RFC 8017 PKCS1-v1-5DigestAlgorithms. An invalid DigestInfo or algorithm identifier will now throw an error.

NOTE: The previous lenient behavior is being changed to be more strict since it could lead to security issues with crafted inputs. It is possible that code may have to handle the errors from these stricter checks.

... (truncated)

Commits

6c5b901 Release 1.3.0.
0f3972a Update changelog.
dc77b39 Fix error checking.
bb822c0 Add advisory links.
d4395fe Update changelog.
a4405bb Improve signature verification tests.
aa9372d Add missing RFC 8017 algorithm identifiers.
3f0b49a Fix signature verification issues.
c20f309 Adjust remaining length.
e27f612 Remove unused option.
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/stormkit-io/app-stormkit-io/network/alerts).

dependabot[bot] commented 2 years ago

The following labels could not be found: npm.

stormkit-io[bot] commented 2 years ago

Deployment failed

This pull request failed while building automatically on Stormkit. You can preview the logs using the following link.

https://app.stormkit.io/app/1644802351/deployments/55892028689331 ❌

stormkit-io[bot] commented 2 years ago

Deployment failed

This pull request failed while building automatically on Stormkit. You can preview the logs using the following link.

https://app.stormkit.io/app/1644802351/deployments/55890383886980 ❌

svedova commented 2 years ago

@stormkit-io deploy

stormkit-io[bot] commented 2 years ago

Deployment failed

This pull request failed while building automatically on Stormkit. You can preview the logs using the following link.

https://app.stormkit.io/app/1644802351/deployments/55926569538702 ❌

svedova commented 2 years ago

@stormkit-io deploy

stormkit-io[bot] commented 2 years ago

Deployment failed

This pull request failed while building automatically on Stormkit. You can preview the logs using the following link.

https://app.stormkit.io/app/1644802351/deployments/55933148748106 ❌

svedova commented 2 years ago

@dependabot rebase

dependabot[bot] commented 2 years ago

Superseded by #344.

stormkit-io / app-stormkit-io