stormkit-io / app-stormkit-io

Stormkit is an all in one solution for Full Stack Javascript applications.
https://app.stormkit.io
GNU General Public License v3.0
64 stars 8 forks source link

Allow `/stormkit deploy` to be typed by others in the team on GitLab #403

Closed svedova closed 2 years ago

svedova commented 2 years ago

One of our customers wrote:

so we currently set up stormkit do only build on demand (to save on bandwith and costs and what not) because it seems to get out of hand. So now someone opened an MR, I want to review it but am not sure about the visual changes, so I wanted to trigger a stormkit build on that MR and I didn’t want to write the MR author to do that for me

Implementation plan

Currently only MR authors are allowed to deploy using the /stormkit deploy comment. We had this as a security feature because as far as I remember, the permission level is not passed with the author information when using GitLab API.

svedova commented 2 years ago

Closing issue, this one is resolved for private projects. If the visibility of a project is INTERNAL or PRIVATE, Stormkit allows any member to execute the command. If the visibility of a project is PUBLIC then only the MR author can deploy.