stormlion227 / PhotoBrowser.Forms

Full screen image viewer(Xamarin.Forms) that includes "pinch to zoom" and "swipe to dismiss" gestures.

MIT License

76 stars 47 forks source link

Compability with Rg.Plugins.Popup #21

Closed nathan1658 closed 5 years ago

nathan1658 commented 5 years ago

Hello, the plugin is excellent and my app do enjoy the convenience on all your hard effort. This issue might be out of the scope, however I found that if I try to view the PhotoBrowser inside the pop up screen, nothing happened on iOS but works on android. I'm beginner of iOS developer but i suspect there might be something related to the code below in MyMWPhotoBrowser: UIApplication.SharedApplication.KeyWindow.RootViewController.PresentViewController(new UINavigationController(browser), true, null);

Any idea to work with it? Thanks!

https://github.com/rotorgames/Rg.Plugins.Popup

didacvm commented 5 years ago

I'm having the same issue. Log output: Warning: Attempt to present <UINavigationController: 0x1124e0c00> on <RgPopupPlatformRenderer: 0x1165511a0> which is already presenting <Rg_Plugins_Popup_IOS_Renderers_PopupPageRenderer: 0x1165489c0>

And if I popup all RGPopups before: Warning: Attempt to present <UINavigationController: 0x1541fb800> on <Xamarin_Forms_Platform_iOS_PlatformRenderer: 0x153d909f0> whose view is not in the window hierarchy!

didacvm commented 5 years ago

@nathan1658 I actually solved it. Plese refer to the pull request:

22

Thanks.

nathan1658 commented 5 years ago

@didacvm Nice thanks for the quick solution!

LeoJHarris commented 5 years ago

@didacvm I saw this issue got merged. Is this working now? Can the issue be closed?

didacvm commented 5 years ago

@LeoJHarris Yes it's working, the issue can be closed.

mimunoz commented 4 years ago

Hi all, this change has been released in Nuget.org? I ask because I've the same issue and Nuget.org show this

Regards!