search

stormpath / Turnstile

An authentication framework for Swift.
Apache License 2.0
165 stars 29 forks source link

BCrypt code quality #1

Open edjiang opened 8 years ago

edjiang commented 8 years ago

I'm not happy with the code quality of the BCrypt implementation I imported. This is one of the few BCrypt implementations in Swift (thanks @joannis for porting @meanjoe45's Swift 1 implementation), so will have to do for now.

BCrypt is passing tests for now, so I'll clean up the API and punt on the decision to audit / improve the code quality myself, or wait for a more popular BCrypt library to pop up on Swift.

edjiang commented 8 years ago

Fixed up a lot of this in fb545e6 so the public API can be more stable, although the internals are still a bit messy. @joannis might wanna check out the changes =]

Joannis commented 8 years ago

Will do!