search

stormpath / express-stormpath

Build simple, secure web applications with Stormpath and Express!
http://docs.stormpath.com/nodejs/express/
Apache License 2.0
325 stars 111 forks source link

Fix field validation #584

Closed the-overengineer closed 7 years ago

the-overengineer commented 7 years ago

Fixes several issues with the account field validation helper:

  1. Error generation used field.label || field.label instead of field.label || field.name
  2. It considered all falsy values to be missing when required: true, when false or null can be legitimate values.
  3. It did not validate required custom fields directly. It now looks into customData

Fixes https://github.com/stormpath/stormpath-express-react-example/issues/29

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 68.711% when pulling 71b41cc3115fcfd545d9a4b5ad4ddaf4d0eb3543 on fix/registration-field-validation into 81082d86473af0f7ad3ed862ae630d6048248ebb on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.4%) to 70.918% when pulling 3bb57c8cbc1fc121ecbe333457ca7726d8fa556c on fix/registration-field-validation into 81082d86473af0f7ad3ed862ae630d6048248ebb on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.4%) to 70.918% when pulling 3bb57c8cbc1fc121ecbe333457ca7726d8fa556c on fix/registration-field-validation into 81082d86473af0f7ad3ed862ae630d6048248ebb on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.4%) to 70.918% when pulling 3bb57c8cbc1fc121ecbe333457ca7726d8fa556c on fix/registration-field-validation into 81082d86473af0f7ad3ed862ae630d6048248ebb on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.4%) to 70.918% when pulling 3bb57c8cbc1fc121ecbe333457ca7726d8fa556c on fix/registration-field-validation into 81082d86473af0f7ad3ed862ae630d6048248ebb on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.4%) to 70.918% when pulling 3bb57c8cbc1fc121ecbe333457ca7726d8fa556c on fix/registration-field-validation into 81082d86473af0f7ad3ed862ae630d6048248ebb on master.

robertjd commented 7 years ago

Thanks @Tweety-FER ! I've added a test for one more case, LGTM.